Skip to content

Conversation

silviaenma
Copy link

Este PR añade el módulo PPIIMoL al repositorio, permitiendo la detección automática de hélices PPII en proteínas desde PyMOL.

@pslacerda
Copy link
Member

Olá, saludos desde Brazil!

Note that PyMOL currently uses Qt instead of TKinter. Pretty formatted source code!

@speleo3
Copy link
Contributor

speleo3 commented Jul 23, 2025

This pull request doesn't seem to follow the structure of Pymol-script-repo.

Plugins with GUI (tkinter) should be placed in the plugins folder and provide a __init_plugin__(app) or __init__(app) function.

Also, .gitattributes and .gitignore look good, but they need to be converted to LF line ending (maybe add them to .gitattributes with text eol=lf?).

  • .gitattributes Convert to text eol=lf
  • .gitignore Convert to text eol=lf
  • PPIIMoL.py Duplicate of modules/ppiimol/PPIIMoL.py. Remove this one or move it to plugins folder.
  • modules/README.md Remove? This is a spanish description of the entire repository, not the modules folder
  • modules/__init__.py Remove, because modules should not be a module itself
  • modules/ppiimol/PPIIMoL.py Duplicate of the other PPIIMoL.py file, only keep one
  • modules/ppiimol/README.md This describes the original repo but doesn't reflect the layout in this pull request

@silviaenma
Copy link
Author

Thank you for reviewing this pull request!
Please let me know if any adjustments are needed to meet the repository standards.
I’ll be happy to make the required changes.

@pslacerda
Copy link
Member

Please, may you structure your README and code in a single .py file? The README can go into the module docstring.

The docstring is better in English because most users here probably can't read Spanish.

@silviaenma
Copy link
Author

Thanks a lot, Pslacerda y speleo3, I'll get on it!!!

Replaced PPIIMoL.py with version including English docstring
Replaced PPIIMoL.py with version including English docstring
Removed README.md content — merged into module docstring
Forzar finales de línea LF para normalizar archivos de texto
@pslacerda
Copy link
Member

Please transform your 8 files into a single 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants